Replace _wait_until with wait_until #9962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #9962 will improve performances by 10.64%Comparing Summary
Benchmarks breakdown
|
xjules
force-pushed
the
mv_wait_until
branch
5 times, most recently
from
c79398f to
05993bd
Compare
jonathan-eq
reviewed
Feb 6, 2025
Comment on lines
310
to
315
| def _wait_until(condition, timeout, fail_msg): | ||
| start = time.time() | ||
| while not condition(): | ||
| assert start + timeout > time.time(), fail_msg | ||
| time.sleep(0.1) | ||
|
|
There was a problem hiding this comment.
If it is only used one place, do we need it as a separate function?
There was a problem hiding this comment.
Maybe. Shall I refactor then?
There was a problem hiding this comment.
I think that would be good yes. while not condition() does not read too well without any typing.
There was a problem hiding this comment.
Actually there is another wait_until function. I will use that one.
xjules
force-pushed
the
mv_wait_until
branch
2 times, most recently
from
281a354 to
2d699f9
Compare
xjules
force-pushed
the
mv_wait_until
branch
from
2d699f9 to
7cc2519
Compare
xjules
changed the title
xjules
added
the
release-notes:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Utility function _wait_until is used only in a single test function,
so moving it there.replacing it with another (similar) one.Approach
🚗
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable